-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iop: rm ingress, update components #15
Conversation
33305ce
to
1671bf6
Compare
- And enable all components for CI
1671bf6
to
92343f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get an erro:
Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Ingress" in version "networking.k8s.io/v1"
@dagl have you run Note that there is a slight change in the values, described in the sciencemesh documentation (i.e. you have to nest the |
yeah, I did run it, also I don't use iop ingress so that's weird. Here is the output:
|
Prevents the error reported in sciencemesh/charts#15 (review) when the ingress resource is not present on the cluster
Prevents the error reported in sciencemesh/charts#15 (review) when the ingress resource is not present on the cluster
@dagl give it another try, I've fixed an issue that went unnoticed when I introduced the support for the new ingress APIs. Thanks for reporting ❤️ |
Sure, got another error:
|
Prevents the error reported in sciencemesh/charts#15 (review) when the ingress resource is not present on the cluster
@dagl I spotted the issue and extended this check to https://github.com/cs3org/charts/blob/5cbe76370a73ed6375a027de27e375cf1cad845c/revad/templates/ingress.yaml#L20 - it should be fixed now |
Seems to work! |
"enable: true"
for all sub-components on the CI