Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iop: rm ingress, update components #15

Merged
merged 3 commits into from
May 19, 2021

Conversation

SamuAlfageme
Copy link
Member

@SamuAlfageme SamuAlfageme commented May 10, 2021

- And enable all components for CI
Copy link
Collaborator

@dagl dagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get an erro:

Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Ingress" in version "networking.k8s.io/v1"

@SamuAlfageme
Copy link
Member Author

@dagl have you run helm dependency update <local-chart-path>/iop before using the chart to upgrade your deployment?

Note that there is a slight change in the values, described in the sciencemesh documentation (i.e. you have to nest the ingress settings under the gateway key). If you already did that, could you post the ingress manifest generated by helm when doing the upgrade with the --dry-run --debug flags?

@dagl
Copy link
Collaborator

dagl commented May 11, 2021

yeah, I did run it, also I don't use iop ingress so that's weird. Here is the output:

cern@cern1:~/k8s/reva5$ helm upgrade --install -n default iop ~/git/samu/sciencemeshcharts/iop \
  --set wopiserver.enabled=true \
  --set gateway.persistentVolume.enabled=true \
  --set gateway.persistentVolume.existingClaim=iop-pvc \
  --set-file gateway.configFiles.revad\\.toml=standalone.toml \
  --set-file gateway.configFiles.gateway\\.toml=standalone.toml \
  --set-file gateway.configFiles.users\\.json=ext-users-ailleron.json  \
  --set wopiserver.config.iopsecret=* \
  --set gateway.env.REVA_APPPROVIDER_IOPSECRET=* \
  --set gateway.imagePullSecrets.name=regcred \
  -f home-sp.yaml -f reva-sp.yaml -f wopi.yaml -f wopibridge.yaml \
  --dry-run --debug
  
history.go:52: [debug] getting history for release iop
Release "iop" does not exist. Installing it now.
install.go:159: [debug] Original chart version: ""
install.go:176: [debug] CHART PATH: /home/cern/git/samu/sciencemeshcharts/iop

Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Ingress" in version "networking.k8s.io/v1"
helm.go:84: [debug] unable to recognize "": no matches for kind "Ingress" in version "networking.k8s.io/v1"
unable to build kubernetes objects from release manifest
helm.sh/helm/v3/pkg/action.(*Install).Run
        /home/circleci/helm.sh/helm/pkg/action/install.go:252
main.runInstall
        /home/circleci/helm.sh/helm/cmd/helm/install.go:229
main.newUpgradeCmd.func1
        /home/circleci/helm.sh/helm/cmd/helm/upgrade.go:104
github.com/spf13/cobra.(*Command).execute
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:842
github.com/spf13/cobra.(*Command).ExecuteC
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950
github.com/spf13/cobra.(*Command).Execute
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887
main.main
        /home/circleci/helm.sh/helm/cmd/helm/helm.go:83
runtime.main
        /usr/local/go/src/runtime/proc.go:203
runtime.goexit
        /usr/local/go/src/runtime/asm_amd64.s:1357

SamuAlfageme added a commit to SamuAlfageme/cs3orgcharts that referenced this pull request May 11, 2021
Prevents the error reported in sciencemesh/charts#15 (review)
when the ingress resource is not present on the cluster
SamuAlfageme added a commit to cs3org/charts that referenced this pull request May 11, 2021
Prevents the error reported in sciencemesh/charts#15 (review)
when the ingress resource is not present on the cluster
@SamuAlfageme
Copy link
Member Author

SamuAlfageme commented May 11, 2021

@dagl give it another try, I've fixed an issue that went unnoticed when I introduced the support for the new ingress APIs. Thanks for reporting ❤️

@dagl
Copy link
Collaborator

dagl commented May 11, 2021

Sure, got another error:

history.go:52: [debug] getting history for release iop
Release "iop" does not exist. Installing it now.
install.go:159: [debug] Original chart version: ""
install.go:176: [debug] CHART PATH: /home/cern/git/samu/sciencemeshcharts/iop

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "service" in io.k8s.api.networking.v1beta1.IngressBackend
helm.go:84: [debug] error validating "": error validating data: ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "service" in io.k8s.api.networking.v1beta1.IngressBackend
helm.sh/helm/v3/pkg/kube.scrubValidationError
        /home/circleci/helm.sh/helm/pkg/kube/client.go:570
helm.sh/helm/v3/pkg/kube.(*Client).Build
        /home/circleci/helm.sh/helm/pkg/kube/client.go:159
helm.sh/helm/v3/pkg/action.(*Install).Run
        /home/circleci/helm.sh/helm/pkg/action/install.go:250
main.runInstall
        /home/circleci/helm.sh/helm/cmd/helm/install.go:229
main.newUpgradeCmd.func1
        /home/circleci/helm.sh/helm/cmd/helm/upgrade.go:104
github.com/spf13/cobra.(*Command).execute
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:842
github.com/spf13/cobra.(*Command).ExecuteC
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950
github.com/spf13/cobra.(*Command).Execute
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887
main.main
        /home/circleci/helm.sh/helm/cmd/helm/helm.go:83
runtime.main
        /usr/local/go/src/runtime/proc.go:203
runtime.goexit
        /usr/local/go/src/runtime/asm_amd64.s:1357
unable to build kubernetes objects from release manifest
helm.sh/helm/v3/pkg/action.(*Install).Run
        /home/circleci/helm.sh/helm/pkg/action/install.go:252
main.runInstall
        /home/circleci/helm.sh/helm/cmd/helm/install.go:229
main.newUpgradeCmd.func1
        /home/circleci/helm.sh/helm/cmd/helm/upgrade.go:104
github.com/spf13/cobra.(*Command).execute
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:842
github.com/spf13/cobra.(*Command).ExecuteC
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950
github.com/spf13/cobra.(*Command).Execute
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887
main.main
        /home/circleci/helm.sh/helm/cmd/helm/helm.go:83
runtime.main
        /usr/local/go/src/runtime/proc.go:203
runtime.goexit
        /usr/local/go/src/runtime/asm_amd64.s:1357

SamuAlfageme added a commit to cs3org/charts that referenced this pull request May 11, 2021
Prevents the error reported in sciencemesh/charts#15 (review)
when the ingress resource is not present on the cluster
@SamuAlfageme
Copy link
Member Author

@dagl I spotted the issue and extended this check to https://github.com/cs3org/charts/blob/5cbe76370a73ed6375a027de27e375cf1cad845c/revad/templates/ingress.yaml#L20 - it should be fixed now

@dagl
Copy link
Collaborator

dagl commented May 11, 2021

Seems to work!

@dagl dagl merged commit a87bc91 into sciencemesh:master May 19, 2021
@SamuAlfageme SamuAlfageme deleted the iop_ingress_update branch May 19, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants