Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing name of vite config from .ts (typescript) to .mjs (javascript module) avoids vite deprecation message. #2677

Closed
wants to merge 1 commit into from

Conversation

jrochkind
Copy link
Contributor

Vite deprecation message looks like:

remote:        Build with Vite complete: /tmp/build_93418466/public/vite
remote:        The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.

And started in vite 5.x.

Relation to .ts typescript and simple solution suggested from ElMassimo/vite_ruby#431

Seems to work great. test deploy to staging succesful

…t module) avoids vite deprecation message.

Vite deprecation message looks like:

```
remote:        Build with Vite complete: /tmp/build_93418466/public/vite
remote:        The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
```

And started in vite 5.x.

Relation to .ts typescript and simple solution suggested from ElMassimo/vite_ruby#431

Seems to work great.
@jrochkind jrochkind marked this pull request as draft July 16, 2024 18:45
@jrochkind
Copy link
Contributor Author

Better way to do it at #2679 it turns out

@jrochkind jrochkind closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant