Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first take on 'classification' #7

Merged
merged 6 commits into from
Feb 10, 2024
Merged

first take on 'classification' #7

merged 6 commits into from
Feb 10, 2024

Conversation

behrica
Copy link
Member

@behrica behrica commented Feb 10, 2024

work in progress

Just have a look on the "direction" and give feedback of suitable for "noj"

@daslu
Copy link
Member

daslu commented Feb 10, 2024

@behrica Thanks for this fantastic tutorial. It is so helpful and clarifies a lot.

A few thoughts:

  • '[tech.v3.dataset.column :as col] is in a comment, so the namespace cannot be loaded as-is.
  • You do not need to require clay, and you do not need to start it either.
  • Please feel comfortable pushing tutorials directly to main, or merging their PRs, or asking me to read before merging, or whatever you find the simplest.
  • Let us add this chapter to the (work-in-progress) Noj documentation book? To do it, you can add it to the make! call at the dev notebook.
  • Since we are now working on these docs together, let us discuss the structure and workflow. Please let me know if you think we should change anything. Also, probably every namespace should have the authors' names and the date of the last significant update or something like that.
  • There is a Clay bug that makes printed values with < or > print in a strange way. This currently affects printed tensors, etc.
  • In one of your comments, you mention tech.ml.dataset.classification. Probably you meant tech.v3.dataset.categorical, right?

@behrica
Copy link
Member Author

behrica commented Feb 10, 2024

I addressed most of your comments, I believe.

@behrica behrica marked this pull request as ready for review February 10, 2024 19:12
@behrica behrica requested a review from daslu February 10, 2024 19:12
@daslu daslu merged commit 20c7fc6 into scicloj:main Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants