Simplifying data dependencies #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom an attached file
|
@behrica Does it look ok? |
|
yes, looks good. |
|
Datasets which you don't find (but have the file) you could host anywhere on GitHub, and refer to them with the "http://....raw/...." url. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@behrica
Following your comments in Zulip (#kindly-dev>copy/paste from "books"), this draft PR makes a few chapters copy-paste friendly by removing their depdendency on local files or other namespaces.
Note it relies on a git dependency of metamorph.ml with the recent(edit: now it uses the new metamorph.ml release)rdatasetsimrovements. I propose we merge this PR after the next release of metamorph.ml.There are still a couple of chapters that rely on local files:
linear_regression_introandfastmath_vector_word_embeddings. I should see whether their data files can be fetched easily and quickly.