More tests #297
Merged
More tests #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* -f with non-existing file * -f with input file containing comment and empty line * -g with non-numeric address in "CIDR" format * -g with one non-numeric address in start resp. end position * -g with one IPv6 address in start resp. end position
Any Echo Response packet uses a different source address than used for the target, because it is not allowed to use a multicast address as source. This results in extra output in a specific format on standard error. This should work, because IPv6 requires multicast support, and every IPv6 node is supposed to join the "all nodes" multicast group, including the node the test runs on. It at least works on my Ubuntu 20.04 LTS system.
|
That's great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on looking at the coverage report, and adding tests that should exercise more code paths. This should increase code coverage by tests.
This also contains pinging a local IPv6 multicast address. I do not know if this works with the GitHub CI. It does work on my GNU/Linux system at home, and IPv6 requires multicast support, so it should work.
If not all tests work with the GitHub CI, I'll close the pull request and look into the problems.