-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Regularly Print Full Statistics Since Start #243
Comments
Ah, I see that the pull request #244 has been automatically linked to this issue. :-) |
I have closed pull request #244 since there has not been any feedback so far. Perhaps you would like to close the issue as won't fix? |
I like the idea and I would still like the feature to be integrated. I will provide more timely feedback if you re-open or recreate a pull request. Instead of adding another option, what do you think about extending the syntax of the --squiet option? It could be: |
Extending |
With -Q SECS, fping emits information for the just finished interval. This is good for long-running fping processes where one would like to get an update on recent results, ignoring missing responses from older intervals. This seems appropriate for use with other software like netdata or smokeping. But for short(er)-running fping processes, e.g., during a change window, it may be more interesting to get a status update since the beginning of the change window, i.e., the start of fping. Adding a comma followed by the keyword "cumulative" to -Q SECS (i.e., -Q SECS,cumulative) changes the interim reports to output the current per system overall statistics, unless -N is used, too. The new syntax is documented in fping.pod and added to fping -h output. Four tests are added: 1. Characters after SECS are ignored as before. 2. Unknown keywords are ignored as before. 2. Adding ",cumulative" changes -Q output. 3. Adding ",cumulative" also affects the additional -o output. This addresses issue schweikert#243.
With -Q SECS, fping emits information for the just finished interval. This is good for long-running fping processes where one would like to get an update on recent results, ignoring missing responses from older intervals. This seems appropriate for use with other software like netdata or smokeping. But for short(er)-running fping processes, e.g., during a change window, it may be more interesting to get a status update since the beginning of the change window, i.e., the start of fping. Adding a comma followed by the keyword "cumulative" to -Q SECS (i.e., -Q SECS,cumulative) changes the interim reports to output the current per system overall statistics, unless -N is used, too. The new syntax is documented in fping.pod and added to fping -h output. Four tests are added: 1. Characters after SECS are ignored as before. 2. Unknown keywords are ignored as before. 2. Adding ",cumulative" changes -Q output. 3. Adding ",cumulative" also affects the additional -o output. This addresses issue #243.
While I think that the current
-Q, --squiet=SECS
behavior is useful and should kept, I would like to have a variation of this theme, i.e., printing the full statistics that have accumulated so far instead of just those since the last report, optionally available, too.Current
-Q
Output:The current
fping -Q1
output looks as follows:Suggested Optional
-Q --a-new-option
Output:I would suggest to optionally have the following different output:
If used together with the
-o, --outage
option, this would regularly show the accumulated outage times of hosts during, e.g., network changes.I have created a proof-of-concept implementation that introduces the new option
-F, --full
to provide this feature. Adding-F
to a command line with-Q
does not regularly print interval statistics, but instead regularly prints full statistics (since the start offping
). I'll add a pull request for this proof-of-concept implementation in a moment and add it in a new comment to this issue.I am open to using different option names, of course.
What do you think?
Best regards,
Erik
The text was updated successfully, but these errors were encountered: