Fix getting name attribute on cruds/view #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If model has not default name attribute (not 'name', or 'title') (see yii2-gii yii\gii\generators\crud\Generator:221)- in breadcrumps will be used its ID attribute instead of getLabel() method (see yii2-giiant\src\generators\crud\default\views\view.php
By the way in a header of view's page use getLabel() method
So I changed $generator->getNameAttribute() (gii module method) with $generator->genModelNameAttribute() (giiant crud RelationTrait method)
After changing generation looks like
As you can see generator started using getLabel() method of model to get main name attribute