Do not typehint DNF union types #1585
Open
+99
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests coverage based on: https://wiki.php.net/rfc/dnf_types
@goetas I need your opinion on that:
(A&B)|D
could be resolved intoD
, when(A&B)|C|D
intounion<C,D>
Looking at the use cases like ArrayCollections from Doctrine I guess second option might be more intuitive for users, when first safer as it brings back behavior from prev lib versions. 🤔