Create an attribute driver decoupled from the annotations driver, deprecate the annotation based attribute reader #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbabker
force-pushed
the
attribute-driver
branch
from
fea36dd
to
9264c9c
Compare
…recate the annotation based attribute reader
mbabker
force-pushed
the
attribute-driver
branch
from
9264c9c
to
e501fec
Compare
|
whoa, this is cool :) |
|
this is nice :) thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested with #1452 (comment) this makes a new base driver class for annotations and attributes, moves the
loadMetadataForClass()method to that base class for reuse by child objects, and declares methods for child classes to handle loading whatever's needed. The current attribute reader (which implements the AnnotationsReaderinterface) which is used as a decorator around an annotations reader for use inside the annotations driver is deprecated in favor of the new attributes driver.(By design, the first commit here is a rename to try and retain the file history, otherwise doing it all in one go (rightfully) treats
AnnotationOrAttributeDriver.phpas a new file and the blame history gets really ugly; the commits individually show the moves right, even if GitHub's PR viewer doesn't)