Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpstan to 1.0.2 #1363

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Update phpstan to 1.0.2 #1363

merged 1 commit into from
Nov 8, 2021

Conversation

scyzoryck
Copy link
Collaborator

Q A
Bug fix? no
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

Bump phpstan to 1.x, one error ignored, second fixed by fixing PHPDoc.


Line src/JsonSerializationVisitor.php


132 Variable $rs in empty() always exists and is not falsy.


@goetas
Copy link
Collaborator

goetas commented Nov 8, 2021

nice! thanks!

@goetas goetas merged commit 832c8f2 into schmittjoh:master Nov 8, 2021
@scyzoryck scyzoryck deleted the phpstan-1.x branch November 8, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants