-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP attributes support #1332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
goetas
force-pushed
the
joaojacome-php8-attributes
branch
from
July 29, 2021 07:17
170a947
to
06e78d8
Compare
niconoe-
reviewed
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the snippets correctly, when both annotations and attributes are set, priority is given to attributes, right?
This looks like perfectly fine to me, for what it matters.
goetas
force-pushed
the
joaojacome-php8-attributes
branch
from
July 30, 2021 20:08
06e78d8
to
c355c35
Compare
niconoe-
reviewed
Jul 30, 2021
goetas
force-pushed
the
joaojacome-php8-attributes
branch
3 times, most recently
from
July 31, 2021 19:34
9734888
to
c32e81f
Compare
niconoe-
reviewed
Aug 1, 2021
- enable attributes by default - extract attribute cache decoration to private method
goetas
force-pushed
the
joaojacome-php8-attributes
branch
from
August 1, 2021 12:32
c32e81f
to
cd238e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #1320