Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP attributes support #1332

Merged
merged 11 commits into from
Aug 1, 2021
Merged

Add PHP attributes support #1332

merged 11 commits into from
Aug 1, 2021

Conversation

goetas
Copy link
Collaborator

@goetas goetas commented Jul 29, 2021

continuation of #1320

@goetas goetas mentioned this pull request Jul 29, 2021
@goetas goetas force-pushed the joaojacome-php8-attributes branch from 170a947 to 06e78d8 Compare July 29, 2021 07:17
Copy link
Contributor

@niconoe- niconoe- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the snippets correctly, when both annotations and attributes are set, priority is given to attributes, right?
This looks like perfectly fine to me, for what it matters.

src/Annotation/VirtualProperty.php Outdated Show resolved Hide resolved
src/Metadata/Driver/AttributeDriver/AttributeReader.php Outdated Show resolved Hide resolved
@goetas goetas force-pushed the joaojacome-php8-attributes branch from 06e78d8 to c355c35 Compare July 30, 2021 20:08
@goetas goetas force-pushed the joaojacome-php8-attributes branch 3 times, most recently from 9734888 to c32e81f Compare July 31, 2021 19:34
@goetas goetas force-pushed the joaojacome-php8-attributes branch from c32e81f to cd238e0 Compare August 1, 2021 12:32
@goetas goetas merged commit 4fd99d8 into master Aug 1, 2021
@goetas goetas deleted the joaojacome-php8-attributes branch August 3, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants