Fixed object instead of string error introduced by strict_types #533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When extracting transalations with
--dir
option, following error is thrownsimplexml_load_file() expects parameter 1 to be a valid path, object given
This was introduced with adding
strict_types
, assimplexml_load_file
expects string, but resource object is given. As it have__toString()
method it explains how it worked before and how to fix this issue rather easly.Todos
- [ ] Tests- [ ] Documentation- [ ] Changelog