Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed object instead of string error introduced by strict_types #533

Merged

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Mar 17, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License Apache2

Description

When extracting transalations with --dir option, following error is thrown
simplexml_load_file() expects parameter 1 to be a valid path, object given

This was introduced with adding strict_types, as simplexml_load_file expects string, but resource object is given. As it have __toString() method it explains how it worked before and how to fix this issue rather easly.

Todos

- [ ] Tests
- [ ] Documentation
- [ ] Changelog

@ViniTou ViniTou mentioned this pull request Mar 17, 2020
@franmomu
Copy link
Contributor

Thanks for the fix! I was trying to add some test, looks like here should be casted to string as well.

@ViniTou
Copy link
Contributor Author

ViniTou commented Mar 17, 2020

Thanks for the fix! I was trying to add some test, looks like here should be casted to string as well.

Yup, fixed!

@goetas goetas merged commit 4cf57e8 into schmittjoh:master Mar 17, 2020
@goetas
Copy link
Collaborator

goetas commented Mar 17, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants