Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP Notice: "Array to string conversion" #445

Merged
merged 1 commit into from
May 15, 2017
Merged

Fix PHP Notice: "Array to string conversion" #445

merged 1 commit into from
May 15, 2017

Conversation

snpy
Copy link
Contributor

@snpy snpy commented May 15, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? untested case?
Fixed tickets hotfix
License Apache2

Description

Configuration validation was throwing Symfony\Component\Debug\Exception\ContextErrorException caused by:

Notice: Array to string conversion in /Users/marek/workspace/gg/website/vendor/jms/translation-bundle/JMS/TranslationBundle/DependencyInjection/Configuration.php:84

in case provided provided dir is prefixed with not existing bundle.

Wrapping array_keys with implode(', ', ...) fixes the issue.

Todos

  • Tests
  • Documentation
  • Changelog

@gnat42 gnat42 merged commit 524a327 into schmittjoh:master May 15, 2017
@gnat42
Copy link
Collaborator

gnat42 commented May 15, 2017

Thanks a bunch and nice catch!

@snpy
Copy link
Contributor Author

snpy commented May 15, 2017

Thanks for quick merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snpy @gnat42