Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong offset #400

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Fixed wrong offset #400

merged 1 commit into from
Apr 20, 2017

Conversation

deguif
Copy link
Contributor

@deguif deguif commented Sep 9, 2016

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets
License Apache2

Description

Fixed wrong offset when computing a @bundle/folder notation.
Currently the bundle name is bundlinstead of bundle, which generates error when using the console.

@deguif
Copy link
Contributor Author

deguif commented Sep 9, 2016

Fatal error: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 32 bytes) in phar:///usr/bin/composer.phar/src/Composer/DependencyResolver/RuleWatchGraph.php on line 52

Apparently there're some errors with Scrutinizer

@gnat42
Copy link
Collaborator

gnat42 commented Sep 9, 2016

Is there anyway to provide tests for this change?

@deguif
Copy link
Contributor Author

deguif commented Sep 9, 2016

I didn't see any test on the configuration. But maybe I'm wrong ?

@gnat42
Copy link
Collaborator

gnat42 commented Sep 9, 2016

yeah I don't know if anything is there - however it would be nice for us to at least know how to reproduce the error and how this fixes it. Could you provide an example that triggers this bug?

@deguif
Copy link
Contributor Author

deguif commented Sep 9, 2016

Here a very simple command line that will reproduce the problem:
In config.yml

jms_translation:
    configs:
        XXXBUNDLE_CONTROLLER:
            #Replace XXX by a valid bundle name
            dirs: ["@XXXBundle/Controller"] 
            output_dir: "%kernel.root_dir%/../src/XXXBundle/Resources/translations"
            keep: true

Then launch this command:
php bin/console trans:extract en --config=XXXBUNDLE_CONTROLLER

@deguif
Copy link
Contributor Author

deguif commented Sep 12, 2016

I just updated the steps to reproduce, as before the example was wrong.

@gnat42
Copy link
Collaborator

gnat42 commented Apr 20, 2017

I can confirm that this is a bug - I couldn't figure out a way to fix it so I'm just merging.

@gnat42 gnat42 merged commit 7382bd2 into schmittjoh:master Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants