Added a contribution guide #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nyholm
commented
May 14, 2016
Nyholm
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #361 |
| License | MIT |
| If you find a bug or a documentation issue, please report it or even better: fix it :). If you report it, | ||
| please be as precise as possible. Please use the provided template when creating an issue. Your issue is | ||
| more likley to get fast feedback if you are clear and detailed in your report. disclosing the vulnerability. | ||
|
|
There was a problem hiding this comment.
perhaps a stray period there before '...report. disclosing the...'
|
Made a few suggested wording changes. Otherwise looked good to me. |
|
Thank you @gnat42. I liked your suggestions and made changes accordingly. |
|
thanks! 👍 |
|
Thank you for merging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.