-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error due to changed PHPParser API #207
Conversation
PHP Fatal error: Cannot use object of type PHPParser_Comment_Doc as array in C:\www\cw4\vendor\doctrine\annotations\lib\Doctrine\Common\Annotations\DocParser.php on line 351
…t_Doc directly, instead of calling getText() on them.
Functional/TranslationTest seems to be failing, but this seems entirely unrelated to the Extractor changes causing the Fatal error earlier as the extractors are not part of that test's scope. All other tests seem to be passing, so I'm not entirely sure why Scrutinizer is claiming they're erroring out. The fork also fixes issue #204 |
Any idea when this can be merged ? |
I don't know, as far as I know it is ready.. |
…s could be returned there which caused errors.
👍, master is broken, use |
@schmittjoh |
👍 For us... This one is affecting a large number of our projects... LOL. We're doing translations by hand the old way until it's fixed : |
You can instruct composer to temporarily use the fork, that will save you a bunch of work ;) : "repositories": [
{
"type": "vcs",
"url": "https://github.com/vansante/JMSTranslationBundle"
}
] |
any idea why we cannot merge fix into this repo? |
Because no collaborators are responding 😟 |
+1 |
@schmittjoh any update ? |
When is this going to be merged? |
Fix error due to changed PHPParser API
thx for merge |
This patch should fix #205
PHP Fatal error: Cannot use object of type PHPParser_Comment_Doc as
array in
C:\www\cw4\vendor\doctrine\annotations\lib\Doctrine\Common\Annotations\DocParser.php
on line 351