Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error due to changed PHPParser API #207

Merged
merged 4 commits into from
Oct 29, 2014
Merged

Fix error due to changed PHPParser API #207

merged 4 commits into from
Oct 29, 2014

Conversation

vansante
Copy link
Contributor

@vansante vansante commented Aug 1, 2014

This patch should fix #205

PHP Fatal error: Cannot use object of type PHPParser_Comment_Doc as
array in
C:\www\cw4\vendor\doctrine\annotations\lib\Doctrine\Common\Annotations\DocParser.php
on line 351

vansante and others added 3 commits August 1, 2014 15:49
PHP Fatal error:  Cannot use object of type PHPParser_Comment_Doc as
array in
C:\www\cw4\vendor\doctrine\annotations\lib\Doctrine\Common\Annotations\DocParser.php
on line 351
…t_Doc directly, instead of calling getText() on them.
@aeterno00
Copy link
Contributor

Functional/TranslationTest seems to be failing, but this seems entirely unrelated to the Extractor changes causing the Fatal error earlier as the extractors are not part of that test's scope.

All other tests seem to be passing, so I'm not entirely sure why Scrutinizer is claiming they're erroring out.

The fork also fixes issue #204

@auss
Copy link

auss commented Aug 7, 2014

Any idea when this can be merged ?

@vansante
Copy link
Contributor Author

vansante commented Aug 7, 2014

I don't know, as far as I know it is ready..
@schmittjoh ?

…s could be returned there which caused errors.
@damienalexandre
Copy link
Contributor

👍, master is broken, use ~1.1.0.

@Venzon
Copy link

Venzon commented Aug 28, 2014

@schmittjoh
any update about this bug?

@fotomerchant
Copy link

👍 For us... This one is affecting a large number of our projects... LOL. We're doing translations by hand the old way until it's fixed :

@vansante
Copy link
Contributor Author

vansante commented Sep 4, 2014

You can instruct composer to temporarily use the fork, that will save you a bunch of work ;) :

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/vansante/JMSTranslationBundle"
        }
]

@Venzon
Copy link

Venzon commented Sep 4, 2014

any idea why we cannot merge fix into this repo?

@vansante
Copy link
Contributor Author

vansante commented Sep 4, 2014

Because no collaborators are responding 😟

@auss auss mentioned this pull request Sep 8, 2014
@nurikabe
Copy link
Contributor

nurikabe commented Oct 2, 2014

+1

@chbruyand
Copy link

@schmittjoh any update ?

GCth pushed a commit to GCth/JMSTranslationBundle that referenced this pull request Oct 22, 2014
@Majstr
Copy link

Majstr commented Oct 29, 2014

When is this going to be merged?

schmittjoh added a commit that referenced this pull request Oct 29, 2014
Fix error due to changed PHPParser API
@schmittjoh schmittjoh merged commit 8eff567 into schmittjoh:master Oct 29, 2014
@Venzon
Copy link

Venzon commented Oct 29, 2014

thx for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use object of type PHPParser_Comment_Doc as array
10 participants