Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid type annotation for the return value of getTranslationMessages() #508

Closed
arnaud-lb opened this issue Feb 7, 2019 · 0 comments · Fixed by #509
Closed

Invalid type annotation for the return value of getTranslationMessages() #508

arnaud-lb opened this issue Feb 7, 2019 · 0 comments · Fixed by #509

Comments

@arnaud-lb
Copy link
Contributor

Q A
Bundle version master

TranslationContainerInterface::getTranslationMessages() has a return type annotation of array<Message>, however Message is not imported. As a result, it refers to the non-existant FQCN JMS\TranslationBundle\Translation\Message instead of JMS\TranslationBundle\Translation\Model\Message.
arnaud-lb added a commit to arnaud-lb/JMSTranslationBundle that referenced this issue Feb 9, 2019
@arnaud-lb
Import Message, fixes schmittjoh#508
2386563
@arnaud-lb arnaud-lb mentioned this issue Feb 9, 2019
Merged
arnaud-lb added a commit to arnaud-lb/JMSTranslationBundle that referenced this issue Feb 9, 2019
@arnaud-lb
Import Message, fixes schmittjoh#508
cfecc8a
goetas added a commit that referenced this issue Feb 9, 2019
@goetas
Merge pull request #509 from arnaud-lb/fix-508
93c654d 
Import Message, fixes #508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Import Message, fixes #508 arnaud-lb/JMSTranslationBundle
1 participant
@arnaud-lb