Position of @Desc in PHP

[althaus]

Hey,

would it be hard to support the following positioning:

<?php
/** @Desc("Ein Nutzer mit dieser E-Mail-Adresse ist bereits als Projektmitglied eingeladen. Der Zugang wurde noch nicht vom Nutzer bestätigt.") */
$message = $this->get('translator')->trans('project.flash.member.email');
?>

This doesn't get extracted, but I would prefer to not put the annotation before the service call as this uglifies the code.

Could this be implemented or is this somehow limited by the parser?

Cheers
Matthias

[schmittjoh]

It could be implemented, but it might be a bit more complicated than the current implementation.

Feel free to write up a patch though.

[althaus]

Ok... I'll take a look at the code if I can spare some time.

Other things which came up:

Similar to the above the position of @desc for form labels would be nice as

<?php
'label' => 'form.field.label', /** @Desc My Label */
?>

but this prolly doesn't make much sense as the annotation would be after the element an not before?

Second one:
empty_values for choice form fields could be extracted as these can be fed with strings.

[schmittjoh]

Could you open a separate issue for the choice values possibly with an
example?

On Tue, Dec 20, 2011 at 6:10 PM, Matthias Althaus <
reply@reply.github.com

wrote:

Ok... I'll take a look at the code if I can spare some time.

Other things which came up:

Similar to the above the position of @desc for form labels would be nice as

<?php
'label' => 'form.field.label', /** @Desc My Label */
?>

but this prolly doesn't make much sense as the annotation would be after
the element an not before?

Second one:
empty_values for choice form fields could be extracted as these can be
fed with strings.

---

Reply to this email directly or view it on GitHub:

#16 (comment)

[althaus]

Could you open a separate issue for the choice values possibly with an example?

Created #17 for this.

[mvrhov]

I've also bumped on this today. And did a failing testcase first as I thought it's a bug. Here is the diff for it.

--- a/lib/vendor/bundles/JMS/TranslationBundle/Tests/Translation/Extractor/File/DefaultPhpFileExtractorTest.php
+++ b/lib/vendor/bundles/JMS/TranslationBundle/Tests/Translation/Extractor/File/DefaultPhpFileExtractorTest.php
@@ -58,6 +58,11 @@ class DefaultPhpFileExtractorTest extends BasePhpFileExtractorTest
         $message->addSource(new FileSource($path, 76));
         $expected->add($message);

+        $message = new Message('text.var.assign');
+        $message->setDesc('The var %foo% should be assigned.');
+        $message->addSource(new FileSource($path, 82));
+        $expected->add($message);
+
         $this->assertEquals($expected, $catalogue);
     }

--- a/lib/vendor/bundles/JMS/TranslationBundle/Tests/Translation/Extractor/File/Fixture/Controller.php
+++ b/lib/vendor/bundles/JMS/TranslationBundle/Tests/Translation/Extractor/File/Fixture/Controller.php
@@ -75,4 +75,10 @@ class Controller
     {
         $arr['foo']->trans('text.array_method_call');
     }
-}
\ No newline at end of file
+
+    public function assignToVar()
+    {
+        /** @Desc("The var %foo% should be assigned.") */
+        $err = $this->translator->trans('text.var.assign', array('%foo%' => 'fooVar'));
+    }
+}