filter dimmers for brightness attribute

schmic · Dec 12, 2023 · 617ed7d · 617ed7d
1 parent 69b70fe
commit 617ed7d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/HaPlugin/Adjustments/DimmerAdjustment.cs b/HaPlugin/Adjustments/DimmerAdjustment.cs
@@ -2,13 +2,20 @@
 {
     using System;
     using System.Collections.Generic;
+
+    using Loupedeck.HomeAssistant.Json;
+
     using Newtonsoft.Json.Linq;
 
     public class DimmerAdjustment : PluginDynamicAdjustment
     {
         private HaPlugin plugin;
 
-        public DimmerAdjustment() : base(true) => this.GroupName = "Dimmer";
+        public DimmerAdjustment() : base(true)
+        {
+            this.GroupName = "Dimmer";
+            this.ResetDisplayName = "Toggle";
+        }
 
         protected override Boolean OnLoad()
         {
@@ -21,9 +28,8 @@ protected override Boolean OnLoad()
                 foreach (KeyValuePair<String, Json.HaState> group in this.plugin.States)
                 {
                     var state = group.Value;
-                    if (state.Entity_Id.StartsWith("light."))
+                    if (this.IsDimmer(state))
                     {
-                        // TODO: filter supported_color_modes["brightness"]
                         this.AddParameter(state.Entity_Id, state.FriendlyName, "Dimmer");
                     }
                 }
@@ -36,6 +42,8 @@ protected override Boolean OnLoad()
             return true;
         }
 
+        private Boolean IsDimmer(HaState state) => state.Entity_Id.StartsWith("light.") && state.Attributes.ContainsKey("brightness");
+
         protected override String GetCommandDisplayName(String actionParameter, PluginImageSize imageSize)
         {
             if (actionParameter.IsNullOrEmpty())

diff --git a/README.md b/README.md
@@ -67,9 +67,6 @@ To get a token you have to log into your Home-Assistant, then go to your Profile
 Someone explained it [here](https://community.home-assistant.io/t/how-to-get-long-lived-access-token/162159/5) as well.
 
 ## Bugs & Issues
-- Dimmers
-  - currently every light is also registered as a dimmer
-  - you must only configure entities as Dimmer if they have a `brightness` attribute
 - Climate Control, current state is WIP
   - visually different to others, no icons, no colors
   - only shows the current state reported from HA
@@ -93,4 +90,5 @@ All icons used from the [Material Design Icons](https://pictogrammers.com/docs/g
 - are they actually of any use?
 
 ## Lights
-- filter dimmers by `brightness` attribute
+- add support for different modes
+  - rgbw/led