-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strong's numbers and Morphological tags in custom format #30
Comments
Thank you for your report. First, both H3306 and G3306 should be supported when importing from MyBible.Zone, but 3306 will be treated the same way as H3306 in old testament and G3306 in new testament. I have never seen the L ones, how should they be converted (to TheWord or other formats?) TheWord only supports For morphology, there already is a "morphology.raw" option, but unfortunately it is not supported by all module formats yet. it is supported by MyBible.Zone import, but not yet for TheWord export (although there is no particular reason for it, as in both formats you can use arbitrary strings for morphology tags). Other formats like Logos will obviously not support it, as they use their own way of encoding morphology which only works for morphology codes that follow the RMAC format. So I'll take this as a feature request to
|
When importing MyBibleZone bibles that contain Strongs numbers starting with L or S, they are treated like the equivalent G/H numbers (depending on OT/NT) and a warning is printed. When importing MyBibleZone with the -Dmybiblezone.morphology.raw=true option, the resulting morphology codes can now also be exported as TheWord (since TheWord does not mandate any format for morphology codes). See #30.
I implemented a quick and dirty fix:
Can you please check if this solves your use case? If not, please clarify how you want these Strongs/Morphology tags treated. In case you cannot compile from the repo and need a precompiled version, please drop me a short notice and I can send you one. |
Thank you so much. Will check it later. Can you please compile a release? |
Find attached a build of 4e2456e: |
Appreciate it so much! |
I checked the build, but I cannot figure out how to add the morphology option in my commandline, as well as I an mot happy at all with you replacing the L and S prefixes to Strong's numbers. I want these to be preserved, since L prefixes to so called Strong's numbers are in reality the references to LXX dictionary. Can you please fix the substitution of L... to be output as L..., as well as NOT TO REPLACE S..., L... and G... numbers on Old Tertament books into H... since if I am converting Septuagint module, everything is screwed up, the greek Strong's being substituted to hebrew ones. |
According to TheWord documentation, Strongs numbers have to look like If you don't want to try, I don't use TheWord so it will take me a while to set up a Windows VM and test it there myself. |
Just leave the L as it is, cince those records need special dictionary. Sure, is gonna be a perfect fit. Currently, I am doing text replacing in SQLite3 database before eporting to TheWord format, and after that doing text replacing to recreate <WT and <WG tags. |
This is a massive commit, touching almost all format modules. Before, the Strong numbers were treated as numbers, by default H in Old Testament and G in New Testament, with some module specific quirks (in case modules support to have custom prefix letters). As @viktor-zhuromskyy pointed out, this is insufficient for modules like LXX which have greek text in OT and which also have an extra L dictionary in addition to G and H. Therefore change the default that every strong reference can have a letter A-Z attached to it and let the modules handle it. If a module only supports G and H (or even only one kind of Strong number), the module can ignore the prefix; other modules can use the prefix. Also provide `StrippedDiffable` options to add prefix to Strongs (G or H depending on Testament), remove prefixes that are default, or completely remove Strongs numbers that have a prefix (if the export format has trouble exporting it). This commit probably needs some more testing before the next release :) See #30.
Ok, so I will now leave the L (or S) prefix in, in addition to Find attached a build of b557089: |
Closing this for now. Feel free to reopen if anything else is open. |
I am converting MyBible modules into TheWord format, and I need to have ability for the Multi Converter to accept and not through out my custom Strong's numbers and Morphological tags.
I have this type of Strongs:
3306, H3306, G3306, L3306
The H3306, G3306, L3306 are not accepted by the converter, at the moment.
I have custom type of Morphological tags.
When I run the converter, I get the following warnings:
Can you please make your code more flexible on treating "malformed" attribute types, please?
The text was updated successfully, but these errors were encountered: