Skip to content
This repository has been archived by the owner on Nov 24, 2018. It is now read-only.

Implement mouseover #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement mouseover #420

wants to merge 1 commit into from

Conversation

Nedomas
Copy link

@Nedomas Nedomas commented Mar 22, 2018

Really needed mouseover feature so just copied @ronanyeah code from this PR #238 onto current master. It still works, no conflicts. Unclear why that is not merged yet, but there was no progress for the last year, so reopening it here.

Plan is to check if tests pass, write some new ones that cover this and possibly have it on the next release.

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • If you've changed APIs, update the documentation in README and /api/README

@ronanyeah
Copy link

@Nedomas I closed it because https://github.com/GoogleChrome/puppeteer got released and I started using that instead, but glad you found the code useful. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants