This repository has been archived by the owner on Nov 24, 2018. It is now read-only.
Prepare for v1.1 release #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adieuadieu
commented
Aug 2, 2017
•
adieuadieu
commented
- rename getHtml() to html()
- fix some linting errors
- manually run prettier (cuz we're momentarily ghetto like that.)
- tweak to yarn.lock
|
🔥 |
joelgriffith
approved these changes
Aug 2, 2017
seangransee
reviewed
Aug 2, 2017
| @@ -159,7 +159,7 @@ const chromeless = new Chromeless({ | |||
| - [`exists(selector: string)`](docs/api.md#api-exists) | |||
| - [`screenshot()`](docs/api.md#api-screenshot) | |||
| - [`pdf(options?: PdfOptions)`](docs/api.md#api-pdf) | |||
| - [`getHtml()`](docs/api.md#api-gethtml) | |||
| - [`html()`](docs/api.md#api-html) | |||
There was a problem hiding this comment.
Ha, I was actually going back and forth about the naming of getHtml() vs html() when I implemented this.
I originally called it getHtml() to avoid confusion with setHtml(), but I actually prefer html(), as it's more in line with the naming of screenshot() and pdf().
I like this change 👍
There was a problem hiding this comment.
@seangransee glad that you like it! The maintainers had a conversation about API design goals yesterday where we decided on this naming convention. I'll share more about the design goals soon in a docs/api-design.md linked to via CONTRIBUTING.md.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.