This repository has been archived by the owner on Nov 24, 2018. It is now read-only.
Evaluate and rimraf... take two! #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adieuadieu
reviewed
Jul 31, 2017
package.json
Outdated
| "build": "rm -rf dist; tsc -d", | ||
| "prepublish": "npm run build; npm test", | ||
| "build": "rimraf dist; tsc -d", | ||
| "prepublishOnly": "npm run build; npm test", |
There was a problem hiding this comment.
While we're at it.. does it make sense to switch the order of these two? E.g. Why bother building if the tests don't pass.
There was a problem hiding this comment.
Agreed. What do you think about using something like np for release orchestration?
adieuadieu
reviewed
Jul 31, 2017
src/util.ts
Outdated
| throw new Error( | ||
| result.exceptionDetails.exception.value || | ||
| result.exceptionDetails.exception.description | ||
| ); |
There was a problem hiding this comment.
Heads-up: I think we're following the "no-semi" rule
There was a problem hiding this comment.
Thanks! Odd that my editor didn't catch it. I'll update that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about that folks, bad rebase and merges. Got too far down the rabbit hole so it was just easier to start fresh :)