-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize inspector #596
Modularize inspector #596
Conversation
I tested this and I think I found a bug: when you scroll down the inspector and change a value in any of the spinner fields, it will move to the top of the panel, requiring you to scroll down again to change the value again. |
@smlpt 🧲😂 I'll check that and fix it, thanks for the report 👍 |
@smlpt This should be fixed now. Can you confirm? |
26e9a49
to
4db185a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please double check how this works with the Text demo? I'm getting exceptions: Color parameter outside of expected range: Red Green
Also, volume timeseries is good, but volumes without a time axis have an incorrect timepoint slider:
During this testing I also tested the atmosphere shader, and it didnt work (on main
either, but it did work when the PR was merged :/)
@kephale atmosphere works on my side, both in this branch and on main. Although I also noticed that something about the blend mode or depth test must be wrong, since it is visible in front of geometrical objects (which is not the case with the AtmosphereExample in scenery), also observed by @moreApi. I also noticed a bug in my Atmosphere input: the azimuth is supposed to go from 0 to 360° according to the properties parameter. But |
@smlpt i'm verifying that the atmosphere is working after a gradle clean 😊 I'd suggest doing the azimuth fix in a separate PR Otherwise the other requested changes still seem to be needed. |
Atmosphere range has been fixed in this PR |
090abe7
to
2418496
Compare
@kephale Known issues should be fixed, good to go from my side 👍 |
When there is a single timepoint volume but the inspector is collapsed i get:
|
2418496
to
3451df5
Compare
This PR modularises the code for the inspector:
Atmosphere
are handled viaAtmosphereProperties
, which extendsInteractiveInspectorCommand
InteractiveInspectorCommand
can have again extensions for specific UI types, this is currently available for Swing asSwingInspectorInteractiveCommandExtension