Avoid calling System.exit from the EDT #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, calling it from the EDT creates a deadlock. SciJava Common registers a JVM shutdown hook thread that calls dispose() on AWT windows it manages (e.g. the main ImageJ2 window), but Window#dispose() internally runs some logic via EventQueue.invokeAndWait. But meanwhile, the System.exit call triggers the shutdown hooks, which use Thread#join to wait for them to finish, thus blocking the EDT. So the invokeAndWait disposing the window can never finish. Therefore, as a workaround here, we avoid the problem by exiting the JVM from a new thread instead.
skalarproduktraum
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, calling it from the EDT creates a deadlock.
SciJava Common registers a JVM shutdown hook thread that calls
dispose()on AWT windows it manages (e.g. the main ImageJ2 window), butWindow#dispose()internally runs some logic viaEventQueue.invokeAndWait.But meanwhile, the
System.exitcall triggers the shutdown hooks, which useThread#jointo wait for them to finish, thus blocking the EDT. So theinvokeAndWaitdisposing the window can never finish.Therefore, as a workaround here, we avoid the problem by exiting the JVM from a new thread instead.
Might fix #538.