Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new config to support #547 #548

Merged
merged 5 commits into from
Feb 29, 2024
Merged

fix: new config to support #547 #548

merged 5 commits into from
Feb 29, 2024

Conversation

thomaschiozzi-tndigit
Copy link
Collaborator

Added new config so that it can be decided wether a comments are stripped from script (of identity providers and attribute providers) before execuition.
Default configuration is that comments are stripped from scripts (security-by-default).

@matteo-s
Copy link
Collaborator

Also please add a test file verifying the successful execution of:

  • scripts with valid comments with default config (ENABLED)
  • scripts with strings containing // in it with the config DISABLED

@thomaschiozzi-tndigit
Copy link
Collaborator Author

Also please add a test file verifying the successful execution of:

  • scripts with valid comments with default config (ENABLED)
  • scripts with strings containing // in it with the config DISABLED

Added required automated tests.
Feel free to comment if the new test are not properly well defined, not sufficient, or more tests are necessary.

@matteo-s matteo-s merged commit 6399c3e into 5.x Feb 29, 2024
@thomaschiozzi-tndigit thomaschiozzi-tndigit deleted the 5.x-fix-547 branch March 1, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants