Bugfix SAML new accounts #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteo-s
requested changes
Nov 9, 2023
src/main/java/it/smartcommunitylab/aac/saml/provider/SamlAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/it/smartcommunitylab/aac/saml/provider/SamlAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/it/smartcommunitylab/aac/saml/provider/SamlAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/it/smartcommunitylab/aac/saml/provider/SamlAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/it/smartcommunitylab/aac/saml/provider/SamlAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/it/smartcommunitylab/aac/saml/provider/SamlAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/it/smartcommunitylab/aac/saml/provider/SamlIdentityProviderConfigMap.java
Show resolved
Hide resolved
matteo-s
requested changes
Nov 13, 2023
src/main/java/it/smartcommunitylab/aac/saml/provider/SamlAuthenticationProvider.java
Show resolved
Hide resolved
matteo-s
force-pushed
the
5.x-bugfix-accounts-saml
branch
from
638b9a6 to
f5a89dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal resolution for issue #311 .
Added option to use the value in a custom SAML attribute as subject identifier when performing a SAML authentication.
The default behaviour (still supported when no attribute is choosen) uses a nonce/random value obtained from the SAML and will result in a new account at each user athentication.