Support matching on variables that are collections #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #123 issue.
I was TDDing this feature outside-in and I've figured out that production code was already able to handle collections for multi prime matching. I'd like to keep the tests though as they'll serve as documentation and to avoid regressions.
I've updated the documentation with an example about using collections when matching variables.
Let me know if you're happy with the PR and I'll squash the commits.
Meanwhile reading the code I've found a couple of TODOs to make the code more robust and maintainable, e.g.
I'll address those in a future PR, if that's ok.