Regularise how Webview handles styling, and add show/hide to Lacci #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
force-pushed
the
hide_show
branch
3 times, most recently
from
0ad036d to
30a16fe
Compare
Closed
Schwad
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add parent styles to Scarpe Webview as a thing, and have the various widgets pick up on that. In order to make styles mergeable, convert all style hash keys to symbol, not a mix of symbol and string.
As a side effect, that means we can set a "hidden" property on the widget in the parent and pick it up in the children.
For added fun, there's a test that makes one of all the top-level widgets, puts it into an array called @ widgets and then does a bunch of stuff to mess with it.
Checklist