Shape rework #315
Merged
Shape rework #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
force-pushed
the
lacci_shape_rework
branch
from
d2d7b7c to
3ed574a
Compare
|
I don't think I'll get to this review today but have it queued up for tomorrow. thanks! shapes are fun |
noahgibbs
force-pushed
the
lacci_shape_rework
branch
from
3ed574a to
5cf5363
Compare
Add draw_context tracking to Shoes::App. Remove ShapeHelper in favour of recording draw commands on the Shoes side and turning it into an SVG path only on the WebviewShape side. With the new draw_context, remove the fill widget, and an incorrect example for it that doesn't work in Shoes3 either.
noahgibbs
force-pushed
the
lacci_shape_rework
branch
from
5cf5363 to
850513f
Compare
Schwad
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #309.
Description
This isn't a 100% full shape rework. For starters, shapes are kind of a weird thing with a lot of interesting Shoes rules about how multiple art-shapes inside work. Instead, this is a mostly functionality-preserving rework to separate Shape properly between display-independent Shoes code and Webview-specific WebviewShape SVG code. I've changed a couple of minor things that were at odds with Shoes3, but mostly not extended the functionality or even changed it much.
Image(if needed, helps for a faster review)
Checklist