Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPDV-6166: Increase Go versions #76

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

martin-majlis-s1
Copy link
Collaborator

Jira Link: https://sentinelone.atlassian.net/browse/DPDV-6166

🥅 Goal

Increase go version to be the same as in Open Telemetry - https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/workflows/build-and-test.yml#L240

🛠️ Solution

Increase go version in tests to the same version that is used by open telemetry.

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/workflows/build-and-test.yml#L237

  unittest-matrix:
    strategy:
      matrix:
        go-version: ["1.22.0", "1.21.7"] # 1.20 is interpreted as 1.2 without quotes

🏫 Testing

Unit tests

@tomaz-s1
Copy link
Collaborator

Looks like build is failing and we also need to bump up go tidy dependency version.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8613ce8) 75.82% compared to head (bbeffa0) 75.82%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   75.82%   75.82%           
=======================================
  Files          12       12           
  Lines        1977     1977           
=======================================
  Hits         1499     1499           
  Misses        399      399           
  Partials       79       79           

@martin-majlis-s1 martin-majlis-s1 added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit e747bcf Feb 15, 2024
10 checks passed
@martin-majlis-s1 martin-majlis-s1 deleted the DPDV-6166-increase-supported-go-versions branch February 15, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants