Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/bb 642 remove dmf specific location handling #2613

Conversation

KillianG
Copy link
Contributor

@KillianG KillianG commented Jan 24, 2025

This change has been tested with zenko CI and on a real platform, I didn't see any issue

@bert-e
Copy link
Contributor

bert-e commented Jan 24, 2025

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@KillianG
Copy link
Contributor Author

/approve

@francoisferrand francoisferrand changed the base branch from development/8.6 to development/9.0 February 7, 2025 18:40
@francoisferrand francoisferrand force-pushed the improvement/BB-642-remove-dmf-specific-location-handling branch from d1c459d to cc49c10 Compare February 7, 2025 18:44
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.13%. Comparing base (761d51a) to head (87851db).
Report is 1 commits behind head on development/9.0.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
extensions/lifecycle/LifecycleQueuePopulator.js 56.45% <ø> (+0.06%) ⬆️

... and 3 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 75.37% <ø> (ø)
Core Library 75.84% <ø> (-0.04%) ⬇️
Ingestion 68.97% <ø> (+0.35%) ⬆️
Lifecycle 76.16% <ø> (+0.01%) ⬆️
Oplog Populator 85.06% <ø> (ø)
Replication 57.79% <ø> (ø)
Bucket Scanner 85.60% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.0    #2613      +/-   ##
===================================================
+ Coverage            71.11%   71.13%   +0.01%     
===================================================
  Files                  201      201              
  Lines                13334    13332       -2     
===================================================
+ Hits                  9483     9484       +1     
+ Misses                3841     3838       -3     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.52% <ø> (+<0.01%) ⬆️
api:routes 9.34% <ø> (+<0.01%) ⬆️
bucket-scanner 85.60% <ø> (ø)
ingestion 12.27% <ø> (+0.03%) ⬆️
lib 7.36% <ø> (-0.01%) ⬇️
lifecycle 18.84% <ø> (+0.01%) ⬆️
notification 1.07% <ø> (+<0.01%) ⬆️
replication 18.63% <ø> (+<0.01%) ⬆️
unit 48.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@francoisferrand francoisferrand force-pushed the improvement/BB-642-remove-dmf-specific-location-handling branch from cc49c10 to 87851db Compare February 14, 2025 17:58
@scality scality deleted a comment from bert-e Feb 14, 2025
@scality scality deleted a comment from KillianG Feb 14, 2025
@bert-e
Copy link
Contributor

bert-e commented Feb 14, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6

Please check the status of the associated issue BB-642.

Goodbye killiang.

The following options are set: approve

@bert-e bert-e merged commit 87851db into development/9.0 Feb 14, 2025
9 checks passed
@bert-e bert-e deleted the improvement/BB-642-remove-dmf-specific-location-handling branch February 14, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants