Improvement/bb 585 bump deps

[benzekrimaha]

Issue: BB-585

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.14%. Comparing base (3814828) to head (dcfde66).
Report is 15 commits behind head on development/9.0.

Additional details and impacted files

Files with missing lines	Coverage Δ
bin/backbeat.js	48.14% <ø> (ø)
extensions/gc/GarbageCollector.js	40.90% <ø> (ø)
extensions/gc/GarbageCollectorProducer.js	82.60% <ø> (ø)
extensions/gc/service.js	0.00% <ø> (ø)
extensions/index.js	100.00% <100.00%> (ø)
extensions/ingestion/IngestionQueuePopulator.js	73.01% <ø> (ø)
extensions/ingestion/constants.js	100.00% <ø> (ø)
extensions/lifecycle/LifecycleQueuePopulator.js	56.45% <100.00%> (ø)
...ecycle/bucketProcessor/LifecycleBucketProcessor.js	79.48% <ø> (ø)
extensions/lifecycle/bucketProcessor/task.js	0.00% <ø> (ø)
... and 52 more

Components	Coverage Δ
Bucket Notification	75.37% <ø> (ø)
Core Library	75.86% <100.00%> (ø)
Ingestion	68.97% <ø> (ø)
Lifecycle	76.19% <100.00%> (ø)
Oplog Populator	85.06% <100.00%> (ø)
Replication	57.79% <100.00%> (ø)
Bucket Scanner	85.60% <ø> (ø)

@@                 Coverage Diff                 @@
##           development/9.0    #2611      +/-   ##
===================================================
- Coverage            71.15%   71.14%   -0.01%     
===================================================
  Files                  201      201              
  Lines                13336    13333       -3     
===================================================
- Hits                  9489     9486       -3     
  Misses                3837     3837              
  Partials                10       10              

Flag	Coverage Δ
api:retry	9.51% <27.27%> (-0.03%)	⬇️
api:routes	9.32% <27.27%> (-0.03%)	⬇️
bucket-scanner	85.60% <ø> (ø)
ingestion	12.24% <27.27%> (-0.03%)	⬇️
lib	7.35% <27.27%> (-0.03%)	⬇️
lifecycle	18.80% <36.36%> (-0.03%)	⬇️
notification	1.07% <0.00%> (+<0.01%)	⬆️
replication	18.63% <54.54%> (-0.02%)	⬇️
unit	48.15% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[benzekrimaha]

/approve

[francoisferrand]

should not have changed, we should have the same behavior as before the node22 bump?

[Kerkesni]

The initial test case was false, there was a bug in the code that was fixed during the unification (with the previous code, S3C never used the v2 listing) the tests were missed as they didn't fail after the change as they never called done() after _indexesGetOrCreate finished executing.

Bumping the "assert" package made the tests fail, not sure what the exact reason is, might be a performance increase or something else but now the assert function returns before the test ends.

[francoisferrand]

OK, but can we double-check with hopocalipse that we have an issue in the tests (i.e. bucketd must indeed use V2), or is there an issue in the lib (i.e. we should use V1 for bucketd, but we use V2) : maybe s3c should not use v2 listing, and it was done on purpose... aka activating v2 listing in s3c should not be a silent improvement thanks to the unification, but a conscious choice of which everybody should be aware.

[Kerkesni]

In the 7.x branch, listing v1 is only used when forcing it using the forceLegacyListing flag in the config. We kept the same behaviour in 9.x

[bert-e]

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/9.0

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.6

Please check the status of the associated issue BB-585.

Goodbye benzekrimaha.

The following options are set: approve