Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instance): update metadata struct #541

Merged
merged 2 commits into from
Sep 3, 2020
Merged

feat(instance): update metadata struct #541

merged 2 commits into from
Sep 3, 2020

Conversation

QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Sep 3, 2020 •
edited
Loading

This MR introduce a breaking change.

Job done:

  • Adds 3 new Project fields
  • Remove Post, Email and UserAgent fields. It is already effective in the API and has already been announced on the changelog and a status.

@QuentinBrosse QuentinBrosse changed the title feat(instance): add project to metadata feat(instance): update metadata struct Sep 3, 2020
jerome-quere
jerome-quere approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sh4d1
Sh4d1 approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit c0ce17a into scaleway:master Sep 3, 2020
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

@Sh4d1 Sh4d1 Sh4d1 approved these changes

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuentinBrosse @jerome-quere @Sh4d1 @remyleone