Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly convert ipId to ip-id, rename field of DeleteIpRequest #272

Merged
merged 3 commits into from
Dec 10, 2019
Merged

fix: properly convert ipId to ip-id, rename field of DeleteIpRequest #272

merged 3 commits into from
Dec 10, 2019

Conversation

loicbourgois
Copy link
Contributor

No description provided.

QuentinBrosse
QuentinBrosse previously approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicbourgois loicbourgois changed the title fix: properly convert ipId to ip-id fix: properly convert ipId to ip-id, rename field of DeleteIpRequest Dec 10, 2019
kindermoumoute
kindermoumoute approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicbourgois loicbourgois merged commit 3c6b21d into scaleway:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

@QuentinBrosse QuentinBrosse QuentinBrosse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loicbourgois @kindermoumoute @QuentinBrosse