Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add ClientCredentialError #228

Merged
merged 5 commits into from
Nov 13, 2019

Conversation

QuentinBrosse
Copy link
Contributor

No description provided.

@QuentinBrosse QuentinBrosse force-pushed the client-credential-error branch from 4175976 to b972463 Compare November 12, 2019 16:59
Quentin Brosse added 2 commits November 12, 2019 18:21
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, other than that lgtm

Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse changed the title feat: add ClientCredentialError feat(core): add ClientCredentialError Nov 13, 2019
@QuentinBrosse QuentinBrosse merged commit 7a70251 into scaleway:master Nov 13, 2019
@QuentinBrosse QuentinBrosse deleted the client-credential-error branch November 29, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants