Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scw.File): add unmarshal #201

Merged
merged 4 commits into from
Oct 7, 2019
Merged

fix(scw.File): add unmarshal #201

merged 4 commits into from
Oct 7, 2019

Conversation

jerome-quere
Copy link
Contributor

No description provided.

Sh4d1 and others added 2 commits October 3, 2019 20:15
@Sh4d1
fix: scw.File unmarshal
9cf8347 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@jerome-quere
handle binary
08eb7a8
@jerome-quere jerome-quere mentioned this pull request Oct 7, 2019
Closed
QuentinBrosse
QuentinBrosse previously approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kindermoumoute
kindermoumoute approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere changed the title fix: scw.File unmarshal fix(scw.File): add unmarshal Oct 7, 2019
@jerome-quere jerome-quere merged commit 7c99a5a into scaleway:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

@QuentinBrosse QuentinBrosse QuentinBrosse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerome-quere @kindermoumoute @QuentinBrosse @Sh4d1