Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix integration tests #568

Merged
merged 2 commits into from
Sep 3, 2019
Merged

Conversation

QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Sep 3, 2019

  • Fix integration test (TEST_WITH_REAL_API=1) by updating old images:

    • ubuntu-wily -> ubuntu-bionic
    • ubuntu-mini-xenial-25g/X64-2GB -> ubuntu-bionic/DEV1-S
  • Code is now formatted with goimports.

@QuentinBrosse QuentinBrosse marked this pull request as ready for review September 3, 2019 15:03
kindermoumoute
kindermoumoute previously approved these changes Sep 3, 2019
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse changed the title feat: exclude integration tests jobs in MR feat: fix integration tests Sep 3, 2019
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit 503d2c2 into scaleway:master Sep 3, 2019
@QuentinBrosse QuentinBrosse deleted the fix-tests branch September 3, 2019 15:33
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants