Skip to content

fix(instance): delete default values for handle oneof correctly #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix(instance): delete default values for handle oneof correctly #3763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fc21ec
feat: update generated APIs
scaleway-bot Apr 11, 2024
931a7f0
Merge branch 'master' into v1.4811.0
Codelax Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/scw/testdata/test-all-usage-instance-security-group-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ ARGS:
[description] Description of the security group
[project-id] Project ID to use. If none is passed the default project ID will be used
[tags.{index}] Tags of the security group
[project-default=false] Whether this security group becomes the default security group for new Instances
[project-default] Whether this security group becomes the default security group for new Instances
[stateful=true] Whether the security group is stateful or not
[inbound-default-policy=accept] Default policy for inbound rules (unknown_policy | accept | drop)
[outbound-default-policy=accept] Default policy for outbound rules (unknown_policy | accept | drop)
Expand All @@ -35,7 +35,7 @@ ARGS:
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | fr-par-3 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2 | pl-waw-3)

DEPRECATED ARGS:
[organization-default=false] Defines whether this security group becomes the default security group for new Instances
[organization-default] Defines whether this security group becomes the default security group for new Instances

FLAGS:
-h, --help help for create
Expand Down
4 changes: 2 additions & 2 deletions docs/commands/instance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,8 +1121,8 @@ scw instance security-group create [arg=value ...]
| description | | Description of the security group |
| project-id | | Project ID to use. If none is passed the default project ID will be used |
| tags.{index} | | Tags of the security group |
| ~~organization-default~~ | Deprecated<br />Default: `false` | Defines whether this security group becomes the default security group for new Instances |
| project-default | Default: `false` | Whether this security group becomes the default security group for new Instances |
| ~~organization-default~~ | Deprecated | Defines whether this security group becomes the default security group for new Instances |
| project-default | | Whether this security group becomes the default security group for new Instances |
| stateful | Default: `true` | Whether the security group is stateful or not |
| inbound-default-policy | Default: `accept`<br />One of: `unknown_policy`, `accept`, `drop` | Default policy for inbound rules |
| outbound-default-policy | Default: `accept`<br />One of: `unknown_policy`, `accept`, `drop` | Default policy for outbound rules |
Expand Down
2 changes: 0 additions & 2 deletions internal/namespaces/instance/v1/instance_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2108,15 +2108,13 @@ func instanceSecurityGroupCreate() *core.Command {
Required: false,
Deprecated: true,
Positional: false,
Default: core.DefaultValueSetter("false"),
},
{
Name: "project-default",
Short: `Whether this security group becomes the default security group for new Instances`,
Required: false,
Deprecated: false,
Positional: false,
Default: core.DefaultValueSetter("false"),
},
{
Name: "stateful",
Expand Down