Skip to content

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Mar 7, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Monitob Monitob self-assigned this Mar 7, 2023
@Monitob Monitob marked this pull request as draft March 7, 2023 16:29
@codecov-commenter
Copy link

Codecov Report

Merging #2849 (772d582) into master (fd66ebe) will decrease coverage by 0.12%.
The diff coverage is 6.66%.

@@            Coverage Diff             @@
##           master    #2849      +/-   ##
==========================================
- Coverage   74.80%   74.68%   -0.12%     
==========================================
  Files         142      142              
  Lines       28623    28675      +52     
==========================================
+ Hits        21411    21417       +6     
- Misses       6471     6517      +46     
  Partials      741      741              
Impacted Files Coverage Δ
internal/core/arg_file_content.go 10.41% <0.00%> (-1.78%) ⬇️
internal/core/shell.go 8.67% <0.00%> (-1.66%) ⬇️
internal/args/unmarshal.go 77.53% <20.00%> (-1.00%) ⬇️
internal/human/marshal_func.go 36.55% <50.00%> (+2.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Monitob Monitob marked this pull request as ready for review March 8, 2023 10:10
@remyleone remyleone added this pull request to the merge queue Mar 8, 2023
Merged via the queue into scaleway:master with commit 8d354fc Mar 8, 2023
@Monitob Monitob deleted the fix-secret-manager-cli branch March 8, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants