Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add support for autocomplete on bool value #1081

Merged
merged 6 commits into from
Jun 15, 2020
Merged

feat(core): add support for autocomplete on bool value #1081

merged 6 commits into from
Jun 15, 2020

Conversation

jerome-quere
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #919

kindermoumoute
kindermoumoute previously approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

remyleone
remyleone previously approved these changes Jun 10, 2020
View reviewed changes
@remyleone remyleone linked an issue Jun 11, 2020 that may be closed by this pull request
Add autocomplete on boolean value #919
Closed
@jerome-quere jerome-quere dismissed stale reviews from remyleone and kindermoumoute via b74d884 June 15, 2020 17:43
@jerome-quere jerome-quere merged commit ac2741a into scaleway:v2 Jun 15, 2020
@jerome-quere jerome-quere deleted the autocomplete-bool branch June 15, 2020 17:47
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@Monitob
Fix(domain): issue on data attribute (scaleway#1081)
28515d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

@kindermoumoute kindermoumoute kindermoumoute left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add autocomplete on boolean value
3 participants
@jerome-quere @remyleone @kindermoumoute