Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for instance terminate action #921

Closed
remyleone opened this issue Apr 24, 2020 · 0 comments · Fixed by #998
Closed

Add support for instance terminate action #921

remyleone opened this issue Apr 24, 2020 · 0 comments · Fixed by #998
Labels
instance Instance issues, bugs and feature requests

Comments

@remyleone
Copy link
Member

remyleone commented Apr 24, 2020 •
edited
Loading

It could take a very long time to shut down a GP1-L because volume needs to be backed up.

To improve this duration we could rely on instance terminate feature. We need to be careful as this will delete some volume and IP also automatically (we need to check instance API)

We would create in instance/v1/custom_server.go

func serverTerminateCommand() *core.Command

We would also need to add test usage in custom_server_test.go with the usage of this command.

In the command usage, we must be explicit if block volumes are deleted by the API when using terminate
@remyleone remyleone changed the title Add support for instance terminate acttion Add support for instance terminate action Apr 27, 2020
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Apr 30, 2020
@remyleone remyleone linked a pull request May 4, 2020 that will close this issue
feat(core): add debug mode in bootstrap config #997
Closed
@Sh4d1 Sh4d1 removed a link to a pull request May 4, 2020
feat(core): add debug mode in bootstrap config #997
Closed
@jawher jawher mentioned this issue May 4, 2020
Merged
@remyleone remyleone linked a pull request May 4, 2020 that will close this issue
feat(instance): add terminate command #998
Merged
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this issue Mar 3, 2022
@Monitob
fix(object): fix test regression (scaleway#921)
d89e5b7 
* feat(reg): fix test obj

* feat(obj): skip test to be used with cassettes

* feat(obj): skip test to be used with cassettes

* feat(obj): set resource name for test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(instance): add terminate command jawher/scaleway-cli
2 participants
@remyleone @jerome-quere