prompt user by default when terminating an instance with at least 1 b…

…lock volume

internal/namespaces/instance/v1/custom_server.go

@@ -10,6 +10,8 @@ import (
 	"strings"
 	"time"
 
+	"errors"
+
 	"github.com/fatih/color"
 
 	"github.com/hashicorp/go-multierror"
@@ -831,9 +833,17 @@ type customTerminateServerRequest struct {
 	Zone      scw.Zone
 	ServerID  string
 	WithIP    bool
-	WithBlock bool
+	WithBlock withBlock
 }
 
+type withBlock string
+
+const (
+	withBlockPrompt = withBlock("prompt")
+	withBlockTrue   = withBlock("true")
+	withBlockFalse  = withBlock("false")
+)
+
 func serverTerminateCommand() *core.Command {
 	return &core.Command{
 		Short:     `Terminate server`,
@@ -855,7 +865,12 @@ func serverTerminateCommand() *core.Command {
 			{
 				Name:    "with-block",
 				Short:   "Delete the Block Storage volumes attached to the server",
-				Default: core.DefaultValueSetter("true"),
+				Default: core.DefaultValueSetter("prompt"),
+				EnumValues: []string{
+					string(withBlockPrompt),
+					string(withBlockTrue),
+					string(withBlockFalse),
+				},
 			},
 			core.ZoneArgSpec(),
 		},
@@ -897,11 +912,15 @@ func serverTerminateCommand() *core.Command {
 				return nil, err
 			}
 
-			if !terminateServerArgs.WithBlock {
-				// detach block storage volumes before terminating the isntance to preserve them
+			preserveBlockVolumes, err := shouldPreserveBlockVolumes(server, terminateServerArgs.WithBlock)
+			if err != nil {
+				return nil, err
+			}
+
+			if preserveBlockVolumes {
+				// detach block storage volumes before terminating the instance to preserve them
 				var multiErr error
 				for _, volume := range server.Server.Volumes {
-
 					if volume.VolumeType != instance.VolumeTypeBSSD {
 						continue
 					}
@@ -947,3 +966,27 @@ func serverTerminateCommand() *core.Command {
 		},
 	}
 }
+
+func shouldPreserveBlockVolumes(server *instance.GetServerResponse, terminateWithBlock withBlock) (bool, error) {
+	switch terminateWithBlock {
+	case withBlockTrue:
+		return false, nil
+	case withBlockFalse:
+		return true, nil
+	case withBlockPrompt:
+		for _, volume := range server.Server.Volumes {
+			if volume.VolumeType != instance.VolumeTypeBSSD {
+				continue
+			}
+
+			deleteVolumes, err := interactive.PromptBoolWithConfig(&interactive.PromptBoolConfig{
+				Prompt:       "Do you want to also delete the block volumes attached to this instance ?",
+				DefaultValue: false,
+			})
+			return !deleteVolumes, err
+		}
+		return false, nil
+	default:
+		return false, errors.Errorf("unsupported value %v for with-block", terminateWithBlock)
+	}
+}

internal/namespaces/instance/v1/testdata/test-server-delete-only-block-volumes.stderr.golden

@@ -1,2 +1,2 @@
-successfully deleted ip 51.15.138.78
-successfully deleted volume cli-srv-intelligent-euclid-1 (10 GB b_ssd)
+successfully deleted ip 51.158.108.20
+successfully deleted volume cli-srv-cool-chaplygin-1 (10 GB b_ssd)

internal/namespaces/instance/v1/testdata/test-server-delete-only-local-volumes.stderr.golden

@@ -1,2 +1,2 @@
-successfully deleted ip 51.15.138.78
+successfully deleted ip 51.158.108.20
 successfully deleted volume snapshot-de728daa-0bf6-4c64-abf5-a9477e791c83-2019-03-05_10:13 (20 GB l_ssd)

internal/namespaces/instance/v1/testdata/test-server-delete-with-all-volumes.stderr.golden

@@ -1,3 +1,3 @@
-successfully deleted ip 163.172.146.186
+successfully deleted ip 51.158.108.20
 successfully deleted volume snapshot-de728daa-0bf6-4c64-abf5-a9477e791c83-2019-03-05_10:13 (20 GB l_ssd)
-successfully deleted volume cli-srv-eager-driscoll-1 (10 GB b_ssd)
+successfully deleted volume cli-srv-unruffled-sanderson-1 (10 GB b_ssd)

internal/namespaces/instance/v1/testdata/test-server-terminate-without-block.stderr.golden

@@ -1,2 +1,2 @@
-successfully detached volume cli-srv-zen-pascal-1
+successfully detached volume cli-srv-priceless-rosalind-1
 successfully deleted ip 51.158.108.20