Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor documentation #364

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Refactor documentation #364

merged 6 commits into from
Nov 1, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Nov 1, 2021

This PR refactors the documentation. Please take a look!

@brfrn169 brfrn169 requested a review from feeblefakie November 1, 2021 08:23
@brfrn169 brfrn169 self-assigned this Nov 1, 2021
feeblefakie
feeblefakie reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Overall looking good.
I left some suggestions

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
brfrn169 and others added 2 commits November 1, 2021 22:53
@brfrn169 @feeblefakie
Apply suggestions from code review
7c74261 
Co-authored-by: Hiroyuki Yamada <mogwaing@gmail.com>
@brfrn169
Fix
168f752
@brfrn169 brfrn169 requested a review from feeblefakie November 1, 2021 13:56
feeblefakie
feeblefakie reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm a bit going back and forth...

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
brfrn169 and others added 2 commits November 1, 2021 23:27
@brfrn169 @feeblefakie
Apply suggestions from code review
3285074 
Co-authored-by: Hiroyuki Yamada <mogwaing@gmail.com>
@brfrn169
Fix
7c5a5c5
feeblefakie
feeblefakie approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 107cf70 into master Nov 1, 2021
@brfrn169 brfrn169 deleted the refactor-doc branch November 1, 2021 14:46
brfrn169 added a commit that referenced this pull request Nov 1, 2021
@brfrn169
Refactor documentation (#364)
6d95712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@brfrn169 brfrn169

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brfrn169 @feeblefakie