Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove namespace prefix #333

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Remove namespace prefix #333

merged 1 commit into from
Oct 4, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Oct 4, 2021

This PR removes the namespace prefix things. Note that I don't remove the namespace prefix things from the schema loader because it will be replaced with a new schema tool soon. Please take a look!

@brfrn169 brfrn169 requested a review from feeblefakie October 4, 2021 05:14
@brfrn169 brfrn169 self-assigned this Oct 4, 2021
feeblefakie
feeblefakie approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit eb631a5 into master Oct 4, 2021
@feeblefakie feeblefakie deleted the remove-namespace-prefix branch October 4, 2021 06:47
brfrn169 added a commit that referenced this pull request Oct 31, 2021
@brfrn169
Remove namespace prefix (#333)
b7a6e02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@brfrn169 brfrn169

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brfrn169 @feeblefakie