Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Coordinator backward compatible #331

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Oct 4, 2021

#320 changed the signature of the Coordinator's constructor, which breaks backward compatibility. This PR will add a constructor that has the original signature again and fix the issue. Please take a look!

@brfrn169 brfrn169 requested a review from feeblefakie October 4, 2021 00:35
@brfrn169 brfrn169 self-assigned this Oct 4, 2021
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit eadfb25 into master Oct 4, 2021
@feeblefakie feeblefakie deleted the make-coordinator-backward-compatible branch October 4, 2021 00:54
brfrn169 added a commit that referenced this pull request Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants