Add Table metadata cache expiration configuration #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feeblefakie
reviewed
Sep 30, 2021
| CacheBuilder<Object, Object> builder = CacheBuilder.newBuilder(); | ||
| long tableMetadataCacheExpirationTimeSecs = config.getTableMetadataCacheExpirationTimeSecs(); | ||
| if (tableMetadataCacheExpirationTimeSecs > 0) { | ||
| builder.expireAfterWrite(tableMetadataCacheExpirationTimeSecs, TimeUnit.SECONDS); |
There was a problem hiding this comment.
I'm not really sure about the use case of specifying the expiration time. Can you clarify?
From users' perspective, it seems like it should be cached forever or it should be replaced right after it needs to
be.
There was a problem hiding this comment.
The use case is when the table metadata change happens. As we don't have alter table feature for now, create table and delete table are only the use cases. Anyway, I think we will need to handle alter table cases in the future, so this cache expiration feature will become more important.
feeblefakie
approved these changes
Oct 1, 2021
|
They were successful after rerunning the CIs. I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to set Table metadata cache expiration configuration with the
scalar.db.table_metadata.cache_expiration_time_secsproperty. Please take a look!