Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a backup guide for the Scalar DB server #254

Merged
merged 3 commits into from
Jul 22, 2021

Conversation

brfrn169
Copy link
Collaborator

Please take a look!

@brfrn169 brfrn169 requested a review from feeblefakie July 20, 2021 13:26
@brfrn169 brfrn169 self-assigned this Jul 20, 2021
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Left some suggestions.

docs/backup-restore.md Outdated Show resolved Hide resolved
@@ -23,3 +23,10 @@ One requirement for backup in Scalar DB on JDBC databases is that backups for al
That means that you need to create a consistent snapshot by dumping all tables in a single transaction.
For example, you can use `mysqldump` command with `--single-transaction` option in MySQL and `pg_dump` command in PostgreSQL to achieve that.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, Is this true even when we use ConsensusCommit?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing this!

Yes. mysqldump command with --single-transaction and pg_dump command can take a backup that's automatically recoverable to a transactionally-consistent state. So, it's true even when we use ConsensusCommit.

docs/backup-restore.md Outdated Show resolved Hide resolved
docs/backup-restore.md Outdated Show resolved Hide resolved
docs/backup-restore.md Outdated Show resolved Hide resolved
Co-authored-by: Hiroyuki Yamada <mogwaing@gmail.com>
@brfrn169 brfrn169 requested a review from feeblefakie July 21, 2021 01:21
feeblefakie
feeblefakie previously approved these changes Jul 21, 2021
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!
I revised the sentence I suggested. Sorry!

docs/backup-restore.md Outdated Show resolved Hide resolved
Co-authored-by: Hiroyuki Yamada <mogwaing@gmail.com>
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 822e6ff into master Jul 22, 2021
@feeblefakie feeblefakie deleted the add-backup-guide-for-scalardb-server branch July 22, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants