Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ConsensusCommitWithGrpcStorageIntegrationTest #225

Merged

Conversation

brfrn169
Copy link
Collaborator

I found that I forgot to rename (move) ConsensusCommitWithGrpcStorageIntegrationTest to the server subproject when converting this project to multi-project. This PR does that.

Please take a look!

@brfrn169 brfrn169 added the bug Something isn't working label Jun 22, 2021
@brfrn169 brfrn169 requested a review from feeblefakie June 22, 2021 03:57
@brfrn169 brfrn169 self-assigned this Jun 22, 2021
@feeblefakie feeblefakie added bugfix and removed bug Something isn't working labels Jun 23, 2021
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

BTW, the CI didn't fail for this?

@feeblefakie feeblefakie merged commit e76789a into master Jun 23, 2021
@feeblefakie feeblefakie deleted the rename-ConsensusCommitWithGrpcStorageIntegrationTest branch June 23, 2021 01:35
@brfrn169
Copy link
Collaborator Author

Thank you for reviewing and merging this!

BTW, the CI didn't fail for this?

Right, that's why I wasn't aware of this 😞 Any sourceSets didn't include the file so we didn't see any errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants