Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TableMetadata #2075

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Fix TableMetadata #2075

merged 3 commits into from
Jul 26, 2024

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jul 20, 2024 •
edited
Loading

Description

This PR fixes bugs of TableMetadata introduced in #1907.

Related issues and/or PRs

Changes made

  • Remove a column from encryptedColumnNames when removing the column.
  • Copy encryptedColumnNames in the copy constructor.
  • Added unit tests for encrypted columns.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 self-assigned this Jul 20, 2024
Torch3333
Torch3333 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

feeblefakie
feeblefakie approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

komamitsu
komamitsu approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@brfrn169 brfrn169 merged commit a247823 into master Jul 26, 2024
47 checks passed
@brfrn169 brfrn169 deleted the fix-TableMetadata branch July 26, 2024 10:41
feeblefakie pushed a commit that referenced this pull request Jul 26, 2024
@brfrn169
Fix TableMetadata (#2075)
018a986
@feeblefakie feeblefakie mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torch3333 Torch3333 Torch3333 approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

@komamitsu komamitsu komamitsu approved these changes

Assignees

@brfrn169 brfrn169

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brfrn169 @komamitsu @feeblefakie @Torch3333